Adopt @microbit/eslint-config - #25
Merged
Merged
Conversation
Replaces the legacy .eslintrc.cjs and per-project plugin set with the
shared flat config, moving to ESLint 9. eslint-plugin-storybook stays a
project dependency as its version tracks Storybook's release cycle; the
one-line flat/recommended addition isn't worth a shared config export
until more Storybook conventions accumulate.
Fixes for the type-aware rules the shared config enables:
- Type the postMessage listeners' event.data, previously any, via
narrow local types that the existing per-message casts build on.
- Rework MakeCodeBlocksRendering's empty-code case to derive the
rendered output instead of setting state synchronously in the effect
(react-hooks set-state-in-effect).
- SnippetAnswerTypes uses (string & {}) to keep the named literals in
autocomplete rather than a union the string member absorbs.
- Type info()'s response resp field, previously any via the intersection
with EditorMessageResponse.
- Mark intentionally unawaited promises with void, drop async from
functions with no await, and remove now-unnecessary assertions.
The lockfile is regenerated as npm could not resolve the ESLint major
bump in place.
Deploying makecode-embed with
|
| Latest commit: |
c3f61a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6bdae7dd.makecode-embed.pages.dev |
| Branch Preview URL: | https://shared-eslint-config.makecode-embed.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the legacy .eslintrc.cjs and per-project plugin set with the shared flat config, moving to ESLint 9. eslint-plugin-storybook stays a project dependency as its version tracks Storybook's release cycle; the one-line flat/recommended addition isn't worth a shared config export until more Storybook conventions accumulate.
Fixes for the type-aware rules the shared config enables:
The lockfile is regenerated as npm could not resolve the ESLint major bump in place.